Use SciMLTesting v1.2 (folder-based run_tests)#85
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Merged
Conversation
Convert the test suite to the SciMLTesting v1.2 folder-discovery model:
- runtests.jl is now `using SciMLTesting; run_tests()`. The folder layout is
the single source of dispatch:
* Core = top-level test/*.jl (sampler_tests, bigfloat_tests,
passthrough_rng_tests, alloc_tests), run with the main test env.
* QA = test/qa/ (its own Project.toml sub-env, activated by run_tests).
test_groups.toml is unchanged (Core, QA).
- Extract the previously-inline non-QA testsets into self-contained top-level
Core files (sampler_tests.jl, bigfloat_tests.jl, passthrough_rng_tests.jl);
alloc_tests.jl was already a file. Each is run in its own @safetestset by the
harness, so the exact set of tests per GROUP is preserved.
- Add SciMLTesting + SafeTestsets to the root test deps ([extras]+[targets].test,
with [compat]) and to test/qa/Project.toml. Drop Pkg from the root test deps
and its compat (only the old hand-written QA-activation harness used it).
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisRackauckas-Claude
force-pushed
the
sciml-testing-rollout
branch
from
279349f to
3243c0f
Compare
ChrisRackauckas-Claude
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the PoissonRandom.jl test suite to the SciMLTesting v1.2 folder-discovery model.
What changed
test/runtests.jlis now just:All
GROUPdispatch is handled by the folder layout, which is the single source of truth (alongside the unchangedtest/test_groups.toml).Folder layout / group mapping (matches
test_groups.toml:Core,QA):test/*.jl(sampler_tests.jl,bigfloat_tests.jl,passthrough_rng_tests.jl,alloc_tests.jl), run with the main test env.test/qa/with its ownProject.tomlsub-env (activated automatically byrun_tests).All= Core (no other in-Allnamed groups), QA excluded.The previously-inline non-QA testsets in
runtests.jlare extracted into self-contained top-level Core files (eachusingits own deps). Each Core/QA file is run in its own@safetestsetby the harness, so the exact set of tests run under eachGROUPvalue is unchanged; no assertions were altered.Deps: added
SciMLTesting+SafeTestsetsto the root test deps ([extras]+[targets].test, with[compat]) and totest/qa/Project.toml. DroppedPkgfrom the root test deps + its compat (only the old hand-written QA-activation harness used it;grepconfirms no remainingPkgreferences intest/).test/test_groups.tomlis unchanged.Local verification (Julia 1.11)
Ran all three GROUP scenarios via
Pkg.test()and confirmed behavior equivalence:GROUP=Core-> ranCore/alloc_tests.jl(10),Core/bigfloat_tests.jl(401),Core/passthrough_rng_tests.jl(5),Core/sampler_tests.jl(0@tests -- useserror()-based asserts, as on master). QA not run. Passed.GROUP=QA-> activatedtest/qaenv, ranQA/qa.jl(18). Core not run. Passed.Pkg.test()(All) -> ran the four Core files; QA not run. Passed.This matches the original master per-GROUP behavior (QA ->
qa.jl; else -> sampler + BigFloat + PassthroughRNG + Allocation tests).This supersedes the v1.0.0 harness PR (same branch) and the
canonicalize-safetestsetPR.Ignore until reviewed by @ChrisRackauckas.